Skip to content

Conversation

@mrdrogdrog
Copy link
Contributor

You shouldn't put the the script's arguments in a variable without keeping them as a list because the arguments were merged and then splitted with whitespace. This results in a total mashup of tabs.

See Issue #17852

@msftclas
Copy link

Hi @mrdrogdrog, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@bpasero bpasero removed their assignment Jan 1, 2017
@joaomoreno joaomoreno added this to the January 2017 milestone Jan 3, 2017
@joaomoreno joaomoreno merged commit 5f5ae5b into microsoft:master Jan 3, 2017
@joaomoreno
Copy link
Member

Thanks!

@Tyriar
Copy link
Member

Tyriar commented Jan 25, 2017

@joaomoreno please cc me for Linux CLI stuff, this re-introduced this issue: c2935f2

@Tyriar
Copy link
Member

Tyriar commented Jan 25, 2017

Fixed by looping over the arg array for sudo instead of shifting it 289dbf7

@joaomoreno
Copy link
Member

Ugh! Sorry about that. 🍺

@Tyriar
Copy link
Member

Tyriar commented Jan 26, 2017

No worries, luckily the issue wasn't closed off so I spotted the regression.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants