Fix labels unit tests + root displayed as '.. #18575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@hun1ahpu not a good fix, please keep using |
Member
|
@hun1ahpu did you get my message? |
Contributor
Author
|
@bpasero Yes, i agree it's a bad fix. Will send a new iteration today-tomorrow. |
Member
|
@hun1ahpu great 👍 |
Contributor
Author
|
@bpasero decided to create 2 separate unit tests. it's not easy to read when using nativeSep. |
Member
|
@hun1ahpu looks good, thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iteration on #12040
Unit tests should work for MacOS. Couldn't verify it though.
Also root path is displayed as '.'