Fix sticky scroll hover listeners piling up#260020
Merged
aiday-mar merged 2 commits intomicrosoft:mainfrom Dec 16, 2025
Merged
Conversation
The StickyScrollWidget adds new mouse enter/exit listeners on every render without clearing the old ones so the listeners keep accumulating. Rendering gets very slow once the number of listeners reaches 100000. Fixed by clearing the existing listeners before adding new ones.
aiday-mar
approved these changes
Dec 16, 2025
bpasero
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The StickyScrollWidget adds new mouse enter/exit listeners on every render without clearing the old ones so the listeners keep accumulating. Rendering gets very slow once the number of listeners reaches 100000. Fixed by clearing the existing listeners before adding new ones.