fix implicit pill showing up on edits#275432
Merged
justschen merged 1 commit intomicrosoft:mainfrom Nov 5, 2025
Merged
Conversation
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
dmitrivMS
approved these changes
Nov 5, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the conditional logic for including implicit context in chat requests by removing redundant condition branches and aligning the behavior with the chat.implicitContext.suggestedContext configuration setting.
- Removed the secondary condition branch that checked for non-URI implicit context values
- Consolidated the logic to require all three conditions:
enabled,value, and config setting
amubushar
pushed a commit
to amubushar/vscode
that referenced
this pull request
Nov 5, 2025
This was referenced Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix this issue
Screen.Recording.2025-11-04.at.4.30.59.PM.mov