Fix Swipe to navigate setting missing description #281997#282220
Merged
bpasero merged 4 commits intomicrosoft:mainfrom Dec 10, 2025
Merged
Fix Swipe to navigate setting missing description #281997#282220bpasero merged 4 commits intomicrosoft:mainfrom
bpasero merged 4 commits intomicrosoft:mainfrom
Conversation
Contributor
Author
|
@bpasero Please review the following approach, thank you. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the user-facing description of the workbench.editor.swipeToNavigate setting by clarifying the exact macOS System Preferences path users need to configure. The previous description was ambiguous about which specific setting within "More Gestures" needed to be changed, potentially causing user confusion.
Key Changes
- Added "Swipe between pages" to the system preferences path to explicitly identify the dropdown option users must configure
- Used the
>hierarchy separator and single quotes to clearly denote navigation depth and UI element names - Maintained consistency with existing formatting patterns in the same description
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
bpasero
approved these changes
Dec 10, 2025
lszomoru
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #281997
Description
This PR updates the description for the
swipeToNavigatesetting to strictly follow the macOS System Preferences hierarchy.Previously, the description implied "More Gestures" was the setting itself. This change clarifies that users must navigate into the "Swipe between pages" dropdown located within the "More Gestures" tab.
Formatting Decisions
I chose the format:
...More Gestures > 'Swipe between pages' must be...Instead of:
...More Gestures "Swipe between pages" must be...Reasons:
>): The arrow explicitly denotes navigation depth/hierarchy, separating the Tab from the Setting. Without the arrow, the phrase reads disjointedly.') avoids the need for backslash escapes (\") inside the double-quoted JSON string, keeping the source code cleaner.'Swipe with two or three fingers'.How to Test
Cmd+,).swipe to navigate.