Replace old-style TS modules with namespaces#282862
Merged
mjbvz merged 1 commit intomicrosoft:mainfrom Dec 11, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes the codebase by replacing deprecated TypeScript module declarations with the modern namespace keyword. This change is necessary for compatibility with TypeScript 6.0+ which hard errors on the old module syntax, and TypeScript 7.0 which won't parse it at all.
- Replaces all instances of
export modulewithexport namespace - Replaces all instances of
declare modulewithdeclare namespace - Maintains identical functionality with updated syntax
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/tasks/common/problemMatcher.ts | Updates three exported namespace declarations (FileLocationKind, ProblemLocationKind, ApplyToKind) |
| src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts | Updates globalThis ambient declaration |
| src/vs/workbench/contrib/debug/common/debugProtocol.d.ts | Updates DebugProtocol ambient declaration in auto-generated file |
| src/vs/server/node/remoteExtensionHostAgentServer.ts | Updates vsda native module ambient declaration |
| src/vs/platform/sign/node/signService.ts | Updates vsda native module ambient declaration |
| src/vs/platform/sign/browser/signService.ts | Updates vsdaWeb module ambient declaration |
| src/vs/platform/extensionManagement/node/extensionSignatureVerificationService.ts | Updates vsceSign module ambient declaration |
| src/vs/editor/standalone/browser/standaloneServices.ts | Updates StandaloneServices exported namespace |
All changes are straightforward syntactic replacements with no functional impact. The changes are correct and necessary for TypeScript compatibility.
Member
Author
|
cc @mjbvz |
mjbvz
approved these changes
Dec 11, 2025
Collaborator
|
Thanks! |
Tyriar
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See microsoft/TypeScript#62876
modulehas been frowned on for a very long time, was soft deprecated a few releases ago, hard errors in 6.0, and won't even parse in 7.0.