fix(runSubagent): collect computed attachments#283750
Merged
aeschli merged 2 commits intomicrosoft:mainfrom Dec 16, 2025
Merged
fix(runSubagent): collect computed attachments#283750aeschli merged 2 commits intomicrosoft:mainfrom
aeschli merged 2 commits intomicrosoft:mainfrom
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for collecting computed attachments (automatic instructions) in the runSubagent tool. Previously, the subagent was invoked with an empty variables array, which meant it didn't benefit from automatic instruction collection based on enabled tools and context. The fix ensures that automatic instructions are collected based on the enabled tools configuration before invoking the subagent, consistent with the pattern used in the main chat widget.
Key Changes:
- Added
collectVariablesprivate method that converts enabled tool IDs to full reference names and usesComputeAutomaticInstructionsto collect automatic instructions - Modified the
invokemethod to collect variables before creating the agent request - Added necessary service dependencies and imports
aeschli
approved these changes
Dec 16, 2025
aeschli
approved these changes
Dec 16, 2025
Contributor
|
@przpl Nice, thanks! |
dmitrivMS
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #282310
Example of a
[tool/runSubagent]request with instructions attached to the system prompt: