Refactor virtual model creation logic in MoveLinesCommand#284785
Merged
aiday-mar merged 3 commits intomicrosoft:mainfrom Dec 25, 2025
Merged
Refactor virtual model creation logic in MoveLinesCommand#284785aiday-mar merged 3 commits intomicrosoft:mainfrom
aiday-mar merged 3 commits intomicrosoft:mainfrom
Conversation
SalerSimo
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the virtual model creation logic in MoveLinesCommand to eliminate code duplication. The refactoring introduces a reusable createVirtualModel method that consolidates the shared logic previously duplicated in three separate locations, with an optional contentOverride parameter to handle cases where line content needs customization.
Key Changes
- Introduced
createVirtualModelhelper method that encapsulates virtual model creation with configurable line number mapping - Replaced three inline virtual model definitions with calls to the new helper method
- Added
contentOverrideparameter to allow custom content for specific lines while maintaining the same tokenization logic
aiday-mar
approved these changes
Dec 25, 2025
Tyriar
approved these changes
Dec 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #214879
I refactored the virtual model creation logic. I noticed that the logic used for
tokenization.getLineTokensand forgetLineContentis largely the same, so I introduced acreateVirtualModelmethod that reuses this shared logic. I also added an optional argument to handle cases where the logic fortokenization.getLineTokensandgetLineContentdiffers.