Fix tests that failed in environments where XDG_DATA_HOME is set#285402
Merged
Tyriar merged 2 commits intomicrosoft:mainfrom Jan 4, 2026
Merged
Fix tests that failed in environments where XDG_DATA_HOME is set#285402Tyriar merged 2 commits intomicrosoft:mainfrom
XDG_DATA_HOME is set#285402Tyriar merged 2 commits intomicrosoft:mainfrom
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
Tyriar
approved these changes
Jan 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes test failures that occurred when the XDG_DATA_HOME environment variable is set on the system. The tests were previously only handling the HOME environment variable but not XDG_DATA_HOME, which affected the Fish shell history path resolution in certain environments.
Key Changes:
- Updated test setup/teardown to preserve and restore
XDG_DATA_HOMEenvironment variable - Added explicit deletion of
XDG_DATA_HOMEin test setup to ensure clean test state
lszomoru
approved these changes
Jan 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close: #285400