add Turkish DOS (CP 857) encoding support#300114
Conversation
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
There was a problem hiding this comment.
Pull request overview
Adds Turkish DOS code page 857 (cp857) to the set of encodings VS Code exposes for file open/save/reopen encoding selection and files.encoding configuration.
Changes:
- Register
cp857as a supported encoding with labels “Turkish DOS (CP 857)” / “CP 857”. - Assign sort order so it appears after existing DOS encodings (CP 865/850).
ssg
force-pushed
the
cp857-support
branch
2 times, most recently
from
fd9b936 to
29129b4
Compare
|
Duplicate of #307782 |
|
@bpasero What did make that other PR more eligible than mine? The only difference seems to be the sort order, but I'm not sure of the exact reasoning. I'm asking so I can make better decisions in the future introducing PRs. I don't care about this specific change, as I only care for that it's fixed, but I don't want to waste time unnecessarily either. Thanks! |
|
@ssg can you agree to #300114 (comment) |
|
@microsoft-github-policy-service agree |
Head branch was pushed to by a user without write access
alexr00
left a comment
alexr00
left a comment
There was a problem hiding this comment.
vscode.d.ts changes look good.
Fixes: #300041