contextkey: fix scanner returning '>=' instead of '>' for greater-than operator#307059
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an incorrect lexeme mapping in the context key scanner so that TokenType.Gt reconstructs to > (distinct from TokenType.GtEq which is >=), improving correctness of error messages and any token-to-text reconstruction.
Changes:
- Correct
Scanner.getLexeme(TokenType.Gt)to return>instead of>=.
ulugbekna
approved these changes
Apr 23, 2026
Contributor
ulugbekna
left a comment
ulugbekna
left a comment
There was a problem hiding this comment.
good catch, and thank you for the PR!
pwang347
approved these changes
Apr 23, 2026
auto-merge was automatically disabled
April 23, 2026 16:21
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Scanner.getLexeme()returns'>='for bothTokenType.GtandTokenType.GtEq, making the two operators produce identical text. TheLt/LtEqpair correctly returns'<'and'<='respectively, but theGtcase was set to'>='instead of'>'.Fix
Change the return value for
TokenType.Gtfrom'>='to'>'.