Fix markdown preview scroll feedback loop (#303765)#312237
Merged
Merged
Conversation
mjbvz
approved these changes
Apr 23, 2026
roblourens
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed fix for #303765:
Root cause was due to the
#isScrollingflag that tried to prevent scroll feedback loops. Whenever thescrollTo()function was called while the flag was already true, it would return the cleared flag early and cause the jumpiness seen before.Added a public
isScrolling()function in order to prevent scroll events that occur from the preview to be echoed in the monitor.Screen.Recording.2026-04-23.at.5.40.24.PM.mov