Skip to content

fix: replace typescript.tsdk.desc with new js/ts.tsdk.path#315268

Merged
mjbvz merged 3 commits into
microsoft:mainfrom
thernstig:jsts-tsdk-path
May 11, 2026
Merged

fix: replace typescript.tsdk.desc with new js/ts.tsdk.path#315268
mjbvz merged 3 commits into
microsoft:mainfrom
thernstig:jsts-tsdk-path

Conversation

@thernstig
Copy link
Copy Markdown
Contributor

The configuration "js/ts.tsdk.path" has an incorrect description, as it referenced the deprecated "typescript.tsdk" description.

The configuration "js/ts.tsdk.path" has an incorrect description, as it referenced the
deprecated "typescript.tsdk" description.
Copilot AI review requested due to automatic review settings May 8, 2026 14:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the TypeScript/JavaScript extension’s setting localization so js/ts.tsdk.path no longer reuses the deprecated typescript.tsdk description.

Changes:

  • Adds a dedicated localized description string for js/ts.tsdk.path.
  • Switches js/ts.tsdk.path’s markdownDescription to use the new localization key.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
extensions/typescript-language-features/package.nls.json Adds a new localized string for js/ts.tsdk.path’s markdown description.
extensions/typescript-language-features/package.json Points js/ts.tsdk.path’s markdownDescription to the new localization key.

Comment thread extensions/typescript-language-features/package.nls.json Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment thread extensions/typescript-language-features/package.json
It means localization will be kept intact.
Copy link
Copy Markdown
Collaborator

@mjbvz mjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mjbvz mjbvz enabled auto-merge May 11, 2026 22:00
@mjbvz mjbvz merged commit 830b948 into microsoft:main May 11, 2026
25 checks passed
@vs-code-engineering vs-code-engineering Bot added this to the 1.121.0 milestone May 11, 2026
@thernstig thernstig deleted the jsts-tsdk-path branch May 12, 2026 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants