fix: restore protected modifier on relayCreationTimeoutMs in test helper#316049
Merged
connor4312 merged 2 commits intoMay 13, 2026
Conversation
The `relayCreationTimeoutMs` override in `TestableSSHRemoteAgentHostMainService` was missing its `protected` modifier, causing the mangler to promote it to `public` and fail the `compile-build-with-mangling` step with: ERROR: Protected fields have been made PUBLIC. This hurts minification and is therefore not allowed. Re-add `protected` to the override declaration to keep the field's visibility consistent with the base class and satisfy the mangler.
Contributor
Author
|
@microsoft-github-policy-service agree company="PlayForm" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix compile-build-with-mangling failures by preventing the mangler from promoting SSHRemoteAgentHostMainService.relayCreationTimeoutMs to public due to a public override in the test subclass.
Changes:
- Change
TestableSSHRemoteAgentHostMainService.relayCreationTimeoutMsfromoverride(effectively public) toprotected overrideto match the base class and avoid mangler promotion errors.
Comment on lines
176
to
+177
| /** Public override so tests can shorten the relay creation timeout. */ | ||
| override relayCreationTimeoutMs: number = 30_000; | ||
| protected override relayCreationTimeoutMs: number = 30_000; |
connor4312
previously approved these changes
May 12, 2026
…ngler The field `relayCreationTimeoutMs` is `protected` in the base class. The test subclass `TestableSSHRemoteAgentHostMainService` had overridden it without an explicit access modifier, making it implicitly `public`. The mangler correctly rejected this as it hurts minification. Adding `protected` back satisfied the mangler but caused a TS2445 error since the test was assigning to the field directly on an instance, which is illegal for `protected` members outside the class hierarchy. Fix by adding a narrow public setter `setRelayCreationTimeoutForTest` in the test subclass. The field stays `protected`; the setter provides a legitimate public entry point for tests. Signed-off-by: Nikola Hristov <Nikola@PlayForm.Cloud>
auto-merge was automatically disabled
May 12, 2026 17:32
Head branch was pushed to by a user without write access
Contributor
Author
|
A follow up, as we now encountered: so an additional commit was made specifically for the test - c5061c3 |
connor4312
approved these changes
May 12, 2026
roblourens
approved these changes
May 12, 2026
NikolaRHristov
pushed a commit
to CodeEditorLand/Editor
that referenced
this pull request
May 13, 2026
…-override-1 fix: restore protected modifier on relayCreationTimeoutMs in test helper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #310195 as we're running into:
after
npm install->npm run compile-build