enable CLI when invoked from WSL on modern (RS4) hosts#44945
Merged
Tyriar merged 1 commit intomicrosoft:masterfrom May 15, 2018
0xabu:wsl-cli-fix
Merged
enable CLI when invoked from WSL on modern (RS4) hosts#44945Tyriar merged 1 commit intomicrosoft:masterfrom 0xabu:wsl-cli-fix
Tyriar merged 1 commit intomicrosoft:masterfrom
0xabu:wsl-cli-fix
Conversation
Fixes issue #39892 There's one minor gotchya: this script tests for a modern WSL release (which supports the WSLENV feature) using the existence of /bin/wslpath. Per https://docs.microsoft.com/en-us/windows/wsl/release-notes, wslpath was added in build 17046 but WSLENV is only supported in the subsequent build (17063). Both those builds were only shipped as Windows insider builds, so this test should be safe enough.
Contributor
Author
|
FWIW, I'm reasonably confident that the OSX build failure has nothing to do with this change :) |
Contributor
Author
|
Ping @Tyriar -- any chance of getting this in for April? |
Contributor
|
@0xabu sorry somehow I missed this one completely as it was still on March 😕 and was just on leave, will look at it this week for the May release (it's too late for April). |
Tyriar
approved these changes
May 15, 2018
Contributor
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
Works great! Sorry again about the big delay 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #39892
There's one minor gotchya: this script tests for a modern WSL release
(which supports the WSLENV feature) using the existence of
/bin/wslpath. Per https://docs.microsoft.com/en-us/windows/wsl/release-notes,
wslpath was added in build 17046 but WSLENV is only supported in
the subsequent build (17063). Both those builds were only shipped as
Windows insider builds, so this test should be safe enough.