Skip to content

NPM Scripts: Added configuration option to change default click action#49282

Closed
borgfriend wants to merge 1 commit intomicrosoft:masterfrom
borgfriend:master
Closed

NPM Scripts: Added configuration option to change default click action#49282
borgfriend wants to merge 1 commit intomicrosoft:masterfrom
borgfriend:master

Conversation

@borgfriend
Copy link
Copy Markdown

@borgfriend borgfriend commented May 5, 2018

This allows users to choose what the default operation is going to be when clicking on a task in the npm scripts view.

#49204

@msftclas
Copy link
Copy Markdown

msftclas commented May 5, 2018

CLA assistant check
All CLA requirements met.

@michaeljota
Copy link
Copy Markdown

I really don't know why run is not the default behavior, but glad for this PR to allow the user to set the default. Thanks you.

@egamma
Copy link
Copy Markdown
Member

egamma commented May 8, 2018

@borgfriend thanks for the PR. pls see this comment #49204 (comment) regarding your question.

@michaeljota
Copy link
Copy Markdown

@egamma Thanks for thinking I made this PR, but I'm sorry to say that I didn't.

Thanks.

@egamma
Copy link
Copy Markdown
Member

egamma commented May 14, 2018

@michaeljota fixed the comment thanks!

@egamma
Copy link
Copy Markdown
Member

egamma commented May 28, 2018

@borgfriend I made some tweaks to the PR and merged it manually (will make sure to acknowledge it in the release notes):

  • only offer run and open as selections
  • changed the setting to be a window setting
  • refresh the view when the setting is changed by the user

@egamma egamma closed this May 28, 2018
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants