Show terminals separately in quickOpenTerm and quickOpenView#49758
Merged
Tyriar merged 2 commits intomicrosoft:masterfrom May 14, 2018
Merged
Show terminals separately in quickOpenTerm and quickOpenView#49758Tyriar merged 2 commits intomicrosoft:masterfrom
Tyriar merged 2 commits intomicrosoft:masterfrom
Conversation
b901298 to
3376cae
Compare
Contributor
Author
|
@Tyriar The code pretty much ends up changing from iterating over This seems like a bit of code rep, but I can't think of a way of removing it, other than exporting some method from interface TerminalInTab { // or w/e
tabIndex: number;
terminalIndex: number;
terminal: Terminal;
}and thus we can make the usages outside terminal service be able to just |
9594493 to
00ec762
Compare
Contributor
Author
|
@Tyriar any comments? |
Contributor
Author
|
@Tyriar thanks man! Glad to contribute! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes both
quickOpenTermandquickOpenViewcommand.