Skip to content

Show terminals separately in quickOpenTerm and quickOpenView#49758

Merged
Tyriar merged 2 commits intomicrosoft:masterfrom
gioragutt:terminal_quick_open
May 14, 2018
Merged

Show terminals separately in quickOpenTerm and quickOpenView#49758
Tyriar merged 2 commits intomicrosoft:masterfrom
gioragutt:terminal_quick_open

Conversation

@gioragutt
Copy link
Copy Markdown
Contributor

@gioragutt gioragutt commented May 12, 2018

Fixes both quickOpenTerm and quickOpenView command.

@gioragutt gioragutt force-pushed the terminal_quick_open branch from b901298 to 3376cae Compare May 12, 2018 18:13
@gioragutt gioragutt changed the title Show terminals separately Terminal Quick Open Show terminals separately in Terminal Quick Open May 12, 2018
@msftclas
Copy link
Copy Markdown

msftclas commented May 12, 2018

CLA assistant check
All CLA requirements met.

@gioragutt gioragutt changed the title Show terminals separately in Terminal Quick Open Show terminals separately in quickOpenTerm and quickOpenView May 12, 2018
@gioragutt
Copy link
Copy Markdown
Contributor Author

@Tyriar The code pretty much ends up changing from iterating over tabs or instances, to iterating over the instances in tabs.

This seems like a bit of code rep, but I can't think of a way of removing it, other than exporting some method from TerminalService which returns:

interface TerminalInTab { // or w/e
  tabIndex: number;
  terminalIndex: number;
  terminal: Terminal;
}

and thus we can make the usages outside terminal service be able to just forEach or map/reduce once, instead of doing the nested loops due to having to iterate over terminals in tabs.

@gioragutt gioragutt force-pushed the terminal_quick_open branch from 9594493 to 00ec762 Compare May 12, 2018 20:29
@gioragutt
Copy link
Copy Markdown
Contributor Author

@Tyriar any comments?

Copy link
Copy Markdown
Contributor

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks! 😃

@Tyriar Tyriar added this to the May 2018 milestone May 14, 2018
@Tyriar Tyriar merged commit c43c862 into microsoft:master May 14, 2018
@gioragutt
Copy link
Copy Markdown
Contributor Author

@Tyriar thanks man! Glad to contribute!

@gioragutt gioragutt deleted the terminal_quick_open branch May 14, 2018 16:40
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants