Add activePanel context key#49971
Merged
isidorn merged 1 commit intomicrosoft:masterfrom May 18, 2018
Krzysztof-Cieslak:addIsPanelVisible
Merged
Add activePanel context key#49971isidorn merged 1 commit intomicrosoft:masterfrom Krzysztof-Cieslak:addIsPanelVisible
isidorn merged 1 commit intomicrosoft:masterfrom
Krzysztof-Cieslak:addIsPanelVisible
Conversation
isidorn
reviewed
May 17, 2018
| } | ||
|
|
||
| dispose(): void { | ||
| this.disposables = dispose(this.disposables); |
Collaborator
There was a problem hiding this comment.
Please call super.dispose()
isidorn
reviewed
May 17, 2018
| const id = viewlet.getId(); | ||
|
|
||
| if (this.activePanelContextKey.get() === id) { | ||
| this.activePanelContextKey.set(''); |
Collaborator
There was a problem hiding this comment.
Please call .reset instead
Collaborator
|
@Krzysztof-Cieslak Thanks for the PR. It looks good to me, I left two minor comments. |
Collaborator
|
Actually merging this in and adding the minor things on top. Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #44372
CC: @isidorn