Skip to content

Implement Go To Next/Previous Breakpoint editor actions#50285

Merged
isidorn merged 4 commits intomicrosoft:masterfrom
Krzysztof-Cieslak:goToNextPreviousBreakpoint
May 28, 2018
Merged

Implement Go To Next/Previous Breakpoint editor actions#50285
isidorn merged 4 commits intomicrosoft:masterfrom
Krzysztof-Cieslak:goToNextPreviousBreakpoint

Conversation

@Krzysztof-Cieslak
Copy link
Copy Markdown
Contributor

Fix #31806

CC: @isidorn

@weinand weinand added feature-request Request for new features or functionality debug Debug viewlet, configurations, breakpoints, adapter issues labels May 22, 2018
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

editor Model can be null

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not really checked in any other place in the file ;-)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of doing a .filter on top, please pass a "enabledOnly: true" to the getBreakpoints

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use openBreakpointSource instead

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do this in twice as less lines? seems like a lot of code is duplicated in the next 20 lines?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sorting is unnecessary in the end since debugModel is responsible for sorting its own breakpoints - https://github.com/Microsoft/vscode/blob/cdd8256102433bf52c2f5b05aea312775a34a669/src/vs/workbench/parts/debug/common/debugModel.ts#L1003-L1015

@isidorn
Copy link
Copy Markdown
Collaborator

isidorn commented May 28, 2018

@Krzysztof-Cieslak thanks a lot for your PR. I have commented directly in the file.
Once you address those changes we can merge this in. Thanks!

@isidorn
Copy link
Copy Markdown
Collaborator

isidorn commented May 28, 2018

You seem to have rebased instead of merge. I suggest to create a new branch to cleanup the mess.

@Krzysztof-Cieslak
Copy link
Copy Markdown
Contributor Author

I've figured out my small problems with git, I think it's more or less ready ;-)

@isidorn isidorn merged commit 9bada78 into microsoft:master May 28, 2018
@isidorn
Copy link
Copy Markdown
Collaborator

isidorn commented May 28, 2018

@Krzysztof-Cieslak thanks a lot, this looks great. Merged it in 🍻

@github-actions github-actions Bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Go to next/previous breakpoint

3 participants