fix: add 'allow-forms' to sandbox attribute.#87334
Merged
mjbvz merged 1 commit intomicrosoft:masterfrom Dec 29, 2019
LeuisKen:master
Merged
fix: add 'allow-forms' to sandbox attribute.#87334mjbvz merged 1 commit intomicrosoft:masterfrom LeuisKen:master
mjbvz merged 1 commit intomicrosoft:masterfrom
LeuisKen:master
Conversation
Extensions like "mtxr.sqltools" using form to update configuration, this patch will help them to work with the VS Online Web Edition.
Collaborator
|
Does this also happen with desktop VS Code? Can you also please create an issue in the VS Code repo so that we can verify that this is fixed in the next release |
Contributor
Author
|
Not happened with desktop VS Code. I create this issue to track this problem: #87581 |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extensions like "mtxr.sqltools" using form to update configuration, this patch will help them to work with the VS Online Web Edition.
This PR fixes mtxr/vscode-sqltools#469