Skip to content

Remove scheme restriction for Markdown/Emmet language features#87541

Merged
mjbvz merged 2 commits intomicrosoft:masterfrom
lostintangent:master
Dec 30, 2019
Merged

Remove scheme restriction for Markdown/Emmet language features#87541
mjbvz merged 2 commits intomicrosoft:masterfrom
lostintangent:master

Conversation

@lostintangent
Copy link
Copy Markdown
Member

@lostintangent lostintangent commented Dec 21, 2019

This PR simply removes the scheme restriction from the Markdown and Emmet extension's language features. This allows these features to apply to virtual file systems (e.g. GistPad, in addition to just local files and untitled files. I tested all of these features in local files, non-file based files, as well as within a Live Share session, and everything works as expected 👍

Fixed #87859

// CC @mattbierner

Copy link
Copy Markdown
Collaborator

@mjbvz mjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Can you check the dev tools console too after loading a markdown fold with this change. I think using document selectors without schemes may generate a warning

@jrieken may know more about this

@lostintangent
Copy link
Copy Markdown
Member Author

Will do! If you’re cool with it, I can also change to using arrays of Ianguage IDs, instead of the object selector format.

@jrieken
Copy link
Copy Markdown
Member

jrieken commented Dec 23, 2019

I think using document selectors without schemes may generate a warning

Yes, unless you are explicit e.g via scheme: '*'. That will tell us that you have thought about the situation.

@lostintangent
Copy link
Copy Markdown
Member Author

@jrieken @mjbvz Just pushed an update that explicitly states the * scheme 👍

@mjbvz mjbvz requested a review from octref December 29, 2019 23:39
@mjbvz
Copy link
Copy Markdown
Collaborator

mjbvz commented Dec 29, 2019

@lostintangent Markdown change looks good to me.

Can you also please create an issue for this so that we can link it to the Jan milestone and properly verify it

@lostintangent
Copy link
Copy Markdown
Member Author

@mjbvz Done! #87859.

@mjbvz mjbvz added this to the January 2020 milestone Dec 30, 2019
@mjbvz mjbvz merged commit 780d875 into microsoft:master Dec 30, 2019
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The markdown and emmett language services don't work for virtual file systems

3 participants