Remove scheme restriction for Markdown/Emmet language features#87541
Merged
mjbvz merged 2 commits intomicrosoft:masterfrom Dec 30, 2019
lostintangent:master
Merged
Remove scheme restriction for Markdown/Emmet language features#87541mjbvz merged 2 commits intomicrosoft:masterfrom lostintangent:master
mjbvz merged 2 commits intomicrosoft:masterfrom
lostintangent:master
Conversation
9 tasks
Member
Author
|
Will do! If you’re cool with it, I can also change to using arrays of Ianguage IDs, instead of the object selector format. |
Member
Yes, unless you are explicit e.g via |
Member
Author
Collaborator
|
@lostintangent Markdown change looks good to me. Can you also please create an issue for this so that we can link it to the Jan milestone and properly verify it |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simply removes the scheme restriction from the Markdown and Emmet extension's language features. This allows these features to apply to virtual file systems (e.g. GistPad, in addition to just local files and untitled files. I tested all of these features in local files, non-file based files, as well as within a Live Share session, and everything works as expected 👍
Fixed #87859
// CC @mattbierner