Skip to content

Fixes file drag and drop does not open the explorer pane#88078

Merged
isidorn merged 1 commit intomicrosoft:masterfrom
jeanp413:fix-87596
Jan 6, 2020
Merged

Fixes file drag and drop does not open the explorer pane#88078
isidorn merged 1 commit intomicrosoft:masterfrom
jeanp413:fix-87596

Conversation

@jeanp413
Copy link
Copy Markdown
Contributor

@jeanp413 jeanp413 commented Jan 4, 2020

This PR fixes #87596

@isidorn
Copy link
Copy Markdown
Collaborator

isidorn commented Jan 6, 2020

I have verified this PR fixes the linked issue, thus adding approved.
However I do not fully understand how this fixes it, it would be great if you could clarify a bit @jeanp413

Did we loose this css rule with our refactorings maybe? @sbatten
Also adding @sbatten as reviewer
fyi @sandy081

@isidorn isidorn requested a review from sbatten January 6, 2020 09:49
@jeanp413
Copy link
Copy Markdown
Contributor Author

jeanp413 commented Jan 6, 2020

@isidorn sure.
The issue was caused by the addition of the activity bar indicator because its over the label and badge preventing them from firing the dragover event.
Adding pointer-events: none to the activity bar indicator makes it ignore pointer events and allows the elements underneath become the target of pointer events.

@isidorn
Copy link
Copy Markdown
Collaborator

isidorn commented Jan 6, 2020

Makes perfect sense. Due to that merging this in
fyi @misolori since you added the activity bar indicator.

@isidorn isidorn merged commit add344d into microsoft:master Jan 6, 2020
@isidorn isidorn added this to the January 2020 milestone Jan 6, 2020
@jeanp413 jeanp413 deleted the fix-87596 branch January 6, 2020 16:39
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File drag and drop does not open the Explorer pane.

3 participants