Skip to content

Reduce duplication and make code less opaque#88237

Merged
Tyriar merged 5 commits intomicrosoft:masterfrom
solomatov:terminal-code-cleanup
Jan 13, 2020
Merged

Reduce duplication and make code less opaque#88237
Tyriar merged 5 commits intomicrosoft:masterfrom
solomatov:terminal-code-cleanup

Conversation

@solomatov
Copy link
Copy Markdown
Contributor

@solomatov solomatov commented Jan 7, 2020

This fragment was duplicated two times, and confused me when I saw it.

this._updateFont();
this._updateTheme();

@bpasero bpasero assigned Tyriar and unassigned bpasero Jan 8, 2020
@Tyriar Tyriar added this to the January 2020 milestone Jan 13, 2020
Copy link
Copy Markdown
Contributor

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Tyriar Tyriar merged commit 8631d96 into microsoft:master Jan 13, 2020
@solomatov solomatov deleted the terminal-code-cleanup branch February 5, 2020 20:14
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants