Update Monitor link in nav#16212
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16212 +/- ##
==========================================
+ Coverage 79.78% 80.09% +0.31%
==========================================
Files 160 158 -2
Lines 8508 8472 -36
==========================================
- Hits 6788 6786 -2
+ Misses 1720 1686 -34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@stephaniehobson What we've done for the leadership page, for example, is to add a minimal version of the page to Dev and to Stage, so that it exists at has a tiny bit of content. This page will then be available in the dev-db download that comes with |
|
I added the monitor landing page to dev and stage as Steve suggested above so this should be reviewable after 0030 UTC April 24. |
|
I can confirm this is pulled down to local dev env wonderfully, both the landing page and articles work as expected, sans the usual custom-media images. BTW, should the homepage launchpad link also lead to |
|
@janbrasna good question... probably the same question for /products too. I'll check. |
75961aa to
d193f25
Compare
wen-2018
left a comment
There was a problem hiding this comment.
Question:
- Should the old global nav link be updated too? https://github.com/mozilla/bedrock/blob/main/bedrock/base/templates/includes/protocol/navigation/menus/products.html#L18
- Should this page replace all references of the old https://monitor.mozilla.org/, I still see quite a few references in the code base
|
I checked with Dan in Slack and we're not replacing all references on the site - just the navigation, homepage, and /products in English only. Because it's English only I think we can leave the old navigation since only non-English speakers see it anyway. I updated the PR to be English only. |
One-line summary
Update Monitor link in nav, hompage, and /products.
Significant changes and points to review
Issue / Bugzilla link
Fix #15751
Testing
make preflightto get a copy of the database that includes the /products/monitor/ page