Skip to content

Update Monitor link in nav#16212

Merged
wen-2018 merged 2 commits into
mainfrom
monitor-nav
Apr 25, 2025
Merged

Update Monitor link in nav#16212
wen-2018 merged 2 commits into
mainfrom
monitor-nav

Conversation

@stephaniehobson
Copy link
Copy Markdown
Contributor

@stephaniehobson stephaniehobson commented Apr 22, 2025

One-line summary

Update Monitor link in nav, hompage, and /products.

Significant changes and points to review

  • Links to Monitor in the nav, homepage, and /products pages now go to the monitor CMS landing page.

Issue / Bugzilla link

Fix #15751

Testing

  • Run make preflight to get a copy of the database that includes the /products/monitor/ page
  • http://localhost:8000/ click Products > Mozilla Monitor in the gobal nav.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.09%. Comparing base (a762b48) to head (b698a23).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16212      +/-   ##
==========================================
+ Coverage   79.78%   80.09%   +0.31%     
==========================================
  Files         160      158       -2     
  Lines        8508     8472      -36     
==========================================
- Hits         6788     6786       -2     
+ Misses       1720     1686      -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stevejalim
Copy link
Copy Markdown
Contributor

stevejalim commented Apr 23, 2025

Hrm, you will need to make the monitor pages locally. I'll add instructions for that in a bit so this is a draft PR for now.

@stephaniehobson What we've done for the leadership page, for example, is to add a minimal version of the page to Dev and to Stage, so that it exists at has a tiny bit of content. This page will then be available in the dev-db download that comes with make preflight. That general approach sounds like it'd solve your pain here, I think. (Fresh sqlite exports of Dev, Stage and Prod happen automatically at 0030 UTC and 1230 UTC each day, or can be triggered manually via k8s if need be)

@stephaniehobson
Copy link
Copy Markdown
Contributor Author

I added the monitor landing page to dev and stage as Steve suggested above so this should be reviewable after 0030 UTC April 24.

@stephaniehobson stephaniehobson marked this pull request as ready for review April 23, 2025 22:14
@stephaniehobson stephaniehobson requested a review from a team as a code owner April 23, 2025 22:14
@janbrasna
Copy link
Copy Markdown
Collaborator

janbrasna commented Apr 24, 2025

I can confirm this is pulled down to local dev env wonderfully, both the landing page and articles work as expected, sans the usual custom-media images.

BTW, should the homepage launchpad link also lead to products.monitor.landing? (There's also a prominent card on /products, not sure about that one tho…)

@stephaniehobson
Copy link
Copy Markdown
Contributor Author

@janbrasna good question... probably the same question for /products too. I'll check.

@stephaniehobson stephaniehobson added Do Not Merge Needs Review Awaiting code review Review: µ Code review time: 5 minutes or less labels Apr 24, 2025
@wen-2018 wen-2018 self-assigned this Apr 25, 2025
@wen-2018 wen-2018 removed the Needs Review Awaiting code review label Apr 25, 2025
Copy link
Copy Markdown
Collaborator

@wen-2018 wen-2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question:

  1. Should the old global nav link be updated too? https://github.com/mozilla/bedrock/blob/main/bedrock/base/templates/includes/protocol/navigation/menus/products.html#L18
  2. Should this page replace all references of the old https://monitor.mozilla.org/, I still see quite a few references in the code base

Comment thread bedrock/products/templates/products/landing.html
@stephaniehobson
Copy link
Copy Markdown
Contributor Author

I checked with Dan in Slack and we're not replacing all references on the site - just the navigation, homepage, and /products in English only.

Because it's English only I think we can leave the old navigation since only non-English speakers see it anyway.

I updated the PR to be English only.

Copy link
Copy Markdown
Collaborator

@wen-2018 wen-2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@wen-2018 wen-2018 merged commit 4262a45 into main Apr 25, 2025
5 checks passed
@wen-2018 wen-2018 deleted the monitor-nav branch April 25, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review: µ Code review time: 5 minutes or less

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New Product Introduction Page: Monitor

4 participants