WebGPURenderer: Fix SampledTexture not correctly bound

[RenaudRohlinger]

Related issue: #28268

Description

When resizing a RenderTarget, for example using a PostProcess pipeline with a PassNode, the resize will trigger this.renderTarget.setSize() which will dispatch dispose destroying the associated textures in the backend and then lose the proper binding on the GPU side:

_destroyTexture( texture ) {

		this.backend.destroySampler( texture );
		this.backend.destroyTexture( texture );

		this.delete( texture );

}

This PR fix SampledTexture binding update. Related comment #28268 (comment)
With this fix, the error seems to no longer appears.

This contribution is funded by Utsubo

[RenaudRohlinger]

All E2E testing seems broken on all recent PRs 🤷‍♂️ /cc @Mugen87

[Mugen87]

Sorry, I'm not familiar with the E2E tests so I have no idea what's going wrong. I try to disable E2E testing manually for the moment.

[RenaudRohlinger]

@sunag Does this change seems ok with you? After 2 days of tests I can't reproduce my issue anymore when resizing the window on PostProcess setup. (I would suggest to remove the getter needsBindingsUpdate from NodeSampledTexture too).

[sunag]

@sunag Does this change seems ok with you? After 2 days of tests I can't reproduce my issue anymore when resizing the window on PostProcess setup. (I would suggest to remove the getter needsBindingsUpdate from NodeSampledTexture too).

Exactly what I would suggest. This section, if I'm not mistaken, was supposed to load a VideoTexture url outside the declaration, but I don't think it will be necessary anymore.

Another thing that caught my attention. I think const texture = binding.texture variable should be declared after binding.update() to obtain the updated reference.

[RenaudRohlinger]

Make sense! Indeed needsBindingsUpdate wasn't being used anymore. I cleaned up SampledTexture too.