Skip to content

BufferGeometry: fix clone index data copy#30680

Merged
Mugen87 merged 1 commit into
mrdoob:devfrom
s-rigaud:fix-buffer-geometry-copy
Mar 7, 2025
Merged

BufferGeometry: fix clone index data copy#30680
Mugen87 merged 1 commit into
mrdoob:devfrom
s-rigaud:fix-buffer-geometry-copy

Conversation

@s-rigaud

@s-rigaud s-rigaud commented Mar 7, 2025

Copy link
Copy Markdown
Contributor

Description

Not sure about what was the expected behavior and how data should store the index but the clone method inside BufferAttribute does not take any argument (same for subtypes of BufferAttribute).

@github-actions

github-actions Bot commented Mar 7, 2025

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.02
78.26
336.02
78.26
+0 B
+0 B
WebGPU 523.84
145.45
523.84
145.45
+0 B
+0 B
WebGPU Nodes 523.31
145.34
523.31
145.34
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.06
112.14
465.06
112.14
-1 B
-1 B
WebGPU 594.24
161.05
594.24
161.05
-1 B
-2 B
WebGPU Nodes 549.37
150.49
549.37
150.48
-1 B
-1 B

@Mugen87 Mugen87 added this to the r175 milestone Mar 7, 2025
@Mugen87 Mugen87 merged commit b91fd11 into mrdoob:dev Mar 7, 2025
@s-rigaud s-rigaud deleted the fix-buffer-geometry-copy branch March 12, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants