Skip to content

nodeBuilder: Add abstract reference for buildFunctionCode#30712

Merged
Mugen87 merged 1 commit into
mrdoob:devfrom
s-rigaud:nodebuilder-add-buildfunctioncode-ref
Mar 10, 2025
Merged

nodeBuilder: Add abstract reference for buildFunctionCode#30712
Mugen87 merged 1 commit into
mrdoob:devfrom
s-rigaud:nodebuilder-add-buildfunctioncode-ref

Conversation

@s-rigaud

Copy link
Copy Markdown
Contributor

Description

this.buildFunctionCode is referenced inside NodeBuilder.buildFunctionNode() and defined in both subclasses so an abstract reference could be nice.

@github-actions

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.02
78.26
336.02
78.26
+0 B
+0 B
WebGPU 523.99
145.48
524.05
145.49
+55 B
+7 B
WebGPU Nodes 523.46
145.38
523.51
145.38
+55 B
+3 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.06
112.14
465.06
112.14
+0 B
+0 B
WebGPU 594.38
161.08
594.43
161.08
+55 B
+3 B
WebGPU Nodes 549.5
150.51
549.55
150.52
+55 B
+3 B

@Mugen87 Mugen87 merged commit 43acb6e into mrdoob:dev Mar 10, 2025
@Mugen87 Mugen87 added this to the r175 milestone Mar 10, 2025
@s-rigaud s-rigaud deleted the nodebuilder-add-buildfunctioncode-ref branch March 12, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants