TSL: Fix dispose() when using reflector().#30933
Merged
Merged
Conversation
Mugen87
commented
Apr 15, 2025
|
|
||
| this.backend.destroySampler( texture ); | ||
| this.backend.destroyTexture( texture ); | ||
| if ( this.has( texture ) === true ) { |
Collaborator
Author
There was a problem hiding this comment.
This is to make sure the following does not break the dispose logic:
renderTarget.dispose();
renderTarget.texture.dispose();Since calling dispose() on the render target disposes all of its textures, it's important to ensure dispose() directly called on a texture does not trigger redundant operations.
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
This was referenced Apr 23, 2025
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #30929.
Description
The PR makes sure
ReflectorNode.dispose()works as expected.