Skip to content

LightsNode: Honor spotlight maps in cache key.#30940

Merged
Mugen87 merged 2 commits into
mrdoob:devfrom
Mugen87:dev5
Apr 18, 2025
Merged

LightsNode: Honor spotlight maps in cache key.#30940
Mugen87 merged 2 commits into
mrdoob:devfrom
Mugen87:dev5

Conversation

@Mugen87

@Mugen87 Mugen87 commented Apr 16, 2025

Copy link
Copy Markdown
Collaborator

Fixed #30930.

Description

The existence of a spot light map must be honored in the dynamic light cache key which is computed per frame. Otherwise dynamic changes to a spot light like described in #30930 produce runtime errors.

@github-actions

github-actions Bot commented Apr 16, 2025

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.33
78.33
336.33
78.33
+0 B
+0 B
WebGPU 545.64
151.26
545.72
151.3
+78 B
+40 B
WebGPU Nodes 544.99
151.1
545.07
151.14
+78 B
+40 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.48
112.23
465.48
112.23
+0 B
+0 B
WebGPU 619.26
167.56
619.34
167.59
+78 B
+35 B
WebGPU Nodes 574.13
156.86
574.21
156.89
+78 B
+32 B

@sunag sunag added this to the r176 milestone Apr 16, 2025
Comment thread src/nodes/lighting/LightsNode.js Outdated
@Mugen87 Mugen87 merged commit 4d368fa into mrdoob:dev Apr 18, 2025
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
* LightsNode: Honor spotlight maps in cache key.

* LightsNode: Make spot light hash more robust.
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
* LightsNode: Honor spotlight maps in cache key.

* LightsNode: Make spot light hash more robust.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WebGPURenderer: Unable to remove map from SpotLight.

2 participants