Skip to content

IFFParser: Fix missing Debbuger attribute declarations#30946

Merged
Mugen87 merged 1 commit into
mrdoob:devfrom
s-rigaud:iffparser-debugger-add-default-attribute-values
Apr 18, 2025
Merged

IFFParser: Fix missing Debbuger attribute declarations#30946
Mugen87 merged 1 commit into
mrdoob:devfrom
s-rigaud:iffparser-debugger-add-default-attribute-values

Conversation

@s-rigaud

Copy link
Copy Markdown
Contributor

Description

Add Debugger missing attribute declarations. Also got rid of old var keywords.

@Mugen87

Mugen87 commented Apr 17, 2025

Copy link
Copy Markdown
Collaborator

With this PR, webgl_loader_lwo fails now with a runtime error:

TypeError: Assignment to constant variable.

@s-rigaud s-rigaud force-pushed the iffparser-debugger-add-default-attribute-values branch from e92a793 to 2261bb3 Compare April 17, 2025 19:38
@s-rigaud

Copy link
Copy Markdown
Contributor Author

My bad, rebase went wrong

@Mugen87

Mugen87 commented Apr 17, 2025

Copy link
Copy Markdown
Collaborator

Do you mind removing tsconfig.tsbuildinfo from the PR?

@s-rigaud s-rigaud force-pushed the iffparser-debugger-add-default-attribute-values branch from 2261bb3 to 54328c4 Compare April 18, 2025 00:17
@Mugen87 Mugen87 added this to the r176 milestone Apr 18, 2025
@Mugen87 Mugen87 merged commit 5b83e73 into mrdoob:dev Apr 18, 2025
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
Co-authored-by: Samuel Rigaud <rigaud@gmail.com>
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
Co-authored-by: Samuel Rigaud <rigaud@gmail.com>
@s-rigaud s-rigaud deleted the iffparser-debugger-add-default-attribute-values branch July 7, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants