Skip to content

TSL: Fixes the return value of atomic* nodes#30971

Merged
sunag merged 2 commits into
mrdoob:devfrom
sunag:dev-parents
Apr 22, 2025
Merged

TSL: Fixes the return value of atomic* nodes#30971
sunag merged 2 commits into
mrdoob:devfrom
sunag:dev-parents

Conversation

@sunag

@sunag sunag commented Apr 22, 2025

Copy link
Copy Markdown
Collaborator

Related issue: #30732 (comment)

Description

Detects whether atomic* needs to return a value or can be added to the stack immediately, allowing it to be used inside or outside expressions.

Summary

@sunag sunag added this to the r176 milestone Apr 22, 2025
@github-actions

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.33
78.33
336.33
78.33
+0 B
+0 B
WebGPU 546.51
151.52
546.7
151.58
+193 B
+63 B
WebGPU Nodes 545.86
151.36
546.05
151.43
+193 B
+64 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.78
112.28
465.78
112.28
+0 B
+0 B
WebGPU 620.88
167.96
621.07
168.02
+193 B
+62 B
WebGPU Nodes 575.75
157.27
575.95
157.33
+193 B
+65 B

@sunag sunag marked this pull request as ready for review April 22, 2025 03:40
@sunag sunag merged commit 3bdd438 into mrdoob:dev Apr 22, 2025
@sunag sunag deleted the dev-parents branch April 22, 2025 03:40
@RenaudRohlinger

Copy link
Copy Markdown
Collaborator

Thanks for this @sunag!

RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
* add `parents` properties

* TSL: Fixes the return value of `atomic*` nodes
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
* add `parents` properties

* TSL: Fixes the return value of `atomic*` nodes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants