Add FXAAPass class#31044
Merged
Merged
Conversation
Mugen87
reviewed
May 5, 2025
Mugen87
approved these changes
May 5, 2025
This was referenced May 21, 2025
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
* Added FXAAPass class * Updated JSDocs and indentation * Fixed typo in docs * Update FXAAPass.js * Update FXAAPass.js Fix code style. --------- Co-authored-by: Michael Herzog <michael.herzog@human-interactive.org>
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
* Added FXAAPass class * Updated JSDocs and indentation * Fixed typo in docs * Update FXAAPass.js * Update FXAAPass.js Fix code style. --------- Co-authored-by: Michael Herzog <michael.herzog@human-interactive.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Three.js FXAA implementation is fantastic, but the WebGL pass has always felt unnecessarily cumbersome and more complicated to use than it needs to be.
This pull request simplifies the creation and use of an FXAA pass by creating a new
FXAAPassclass that works in the same way asSMAAPass: rather than having to passFXAAShaderas a parameter of theShaderPassclass and manually manage the size of the pass, you simply create a single class instance which is automatically updated by theEffectComposercalling itssetSizemethod.