Skip to content

TSL: Fix reflector() clear texture and stop update if bounce is false#31110

Merged
sunag merged 1 commit into
mrdoob:devfrom
sunag:dev-reflector-fix
May 15, 2025
Merged

TSL: Fix reflector() clear texture and stop update if bounce is false#31110
sunag merged 1 commit into
mrdoob:devfrom
sunag:dev-reflector-fix

Conversation

@sunag

@sunag sunag commented May 14, 2025

Copy link
Copy Markdown
Collaborator

Description

The PR fixed two issues:

  • Clears the texture if it is not in the viewing angle to avoid artifacts generated in the material that is projected.
  • If bounce=false and it is not in the viewing angle, reflector() stops working.

@sunag sunag added this to the r177 milestone May 14, 2025
@github-actions

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 337.26
78.64
337.26
78.64
+0 B
+0 B
WebGPU 549.59
152.34
549.71
152.38
+120 B
+43 B
WebGPU Nodes 548.94
152.19
549.06
152.23
+120 B
+43 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 467.34
112.95
467.34
112.95
+0 B
+0 B
WebGPU 624.5
169.06
624.5
169.06
+0 B
+0 B
WebGPU Nodes 579.35
158.35
579.35
158.35
+0 B
+0 B

@sunag sunag marked this pull request as ready for review May 15, 2025 04:41
@sunag sunag merged commit 02d84d2 into mrdoob:dev May 15, 2025
12 checks passed
@sunag sunag deleted the dev-reflector-fix branch May 15, 2025 04:42
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant