Skip to content

ColorManagement: Improve Nomenclature.#31152

Merged
Mugen87 merged 3 commits into
mrdoob:devfrom
WestLangley:dev-color_space
May 24, 2025
Merged

ColorManagement: Improve Nomenclature.#31152
Mugen87 merged 3 commits into
mrdoob:devfrom
WestLangley:dev-color_space

Conversation

@WestLangley

@WestLangley WestLangley commented May 23, 2025

Copy link
Copy Markdown
Collaborator

Make the nomenclature more explicit -- and consistent.

See discussion in #30590 (comment).

@github-actions

github-actions Bot commented May 23, 2025

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 337.26
78.64
337.26
78.64
+0 B
+0 B
WebGPU 551.2
152.85
551.04
152.81
-168 B
-43 B
WebGPU Nodes 550.55
152.7
550.39
152.66
-168 B
-44 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 468.12
113.14
468.44
113.28
+324 B
+146 B
WebGPU 625.84
169.43
626.05
169.5
+209 B
+69 B
WebGPU Nodes 580.7
158.75
580.9
158.82
+209 B
+69 B

Comment thread src/nodes/display/ColorSpaceNode.js
Comment thread src/math/ColorManagement.js
@WestLangley WestLangley marked this pull request as ready for review May 23, 2025 19:03
@Mugen87 Mugen87 added this to the r177 milestone May 23, 2025
@Mugen87 Mugen87 merged commit 650a2b8 into mrdoob:dev May 24, 2025
12 checks passed
@Mugen87 Mugen87 changed the title Src: Improve Nomenclature ColorManagement: Improve Nomenclature. May 24, 2025
@WestLangley WestLangley deleted the dev-color_space branch May 24, 2025 18:38
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
* improve nomenclature

* improve nomenclature

* add deprecation warnings
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
* improve nomenclature

* improve nomenclature

* add deprecation warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants