Skip to content

WebGPUBackend: Fix generateMipmaps when used copyFramebufferToTexture()#31163

Merged
sunag merged 1 commit into
mrdoob:devfrom
sunag:dev-fix-mipmaps
May 25, 2025
Merged

WebGPUBackend: Fix generateMipmaps when used copyFramebufferToTexture()#31163
sunag merged 1 commit into
mrdoob:devfrom
sunag:dev-fix-mipmaps

Conversation

@sunag

@sunag sunag commented May 25, 2025

Copy link
Copy Markdown
Collaborator

Fixes #31143

Description

copyFramebufferToTexture() is not generating mipmaps after copying even if the property texture.generateMipmaps is true.

@sunag sunag added this to the r177 milestone May 25, 2025
@github-actions

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 337.26
78.64
337.26
78.64
+0 B
+0 B
WebGPU 551.52
152.93
551.58
152.94
+56 B
+4 B
WebGPU Nodes 550.88
152.78
550.93
152.78
+56 B
+4 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 468.44
113.28
468.44
113.28
+0 B
+0 B
WebGPU 626.53
169.61
626.59
169.62
+56 B
+4 B
WebGPU Nodes 581.38
158.94
581.44
158.94
+56 B
+4 B

@sunag sunag marked this pull request as ready for review May 25, 2025 03:41
@sunag sunag merged commit cacaad1 into mrdoob:dev May 25, 2025
12 checks passed
@sunag sunag deleted the dev-fix-mipmaps branch May 25, 2025 04:09
@ycw

ycw commented May 25, 2025

Copy link
Copy Markdown
Contributor

This PR generated mipmaps twice, L2359, L2399 ?

@sunag

sunag commented May 25, 2025

Copy link
Copy Markdown
Collaborator Author

This PR generated mipmaps twice, L2359, L2399 ?

Fixed

RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WebGPURenderer: Mipmaps are not generated correctly for the WebGPU backend.

2 participants