CSMShadowNode: Fix toggle of castShadow.#31186
Merged
Merged
Conversation
Mugen87
commented
May 27, 2025
| gui.add( params, 'shadows' ).onChange( function ( value ) { | ||
|
|
||
| renderer.shadowMap.enabled = value; | ||
| csmDirectionalLight.castShadow = value; |
Collaborator
Author
There was a problem hiding this comment.
Globally toggling shadows was never an ideal solution. With this PR, CSM shadows can be toggled on light level which is way more intuitive (and practical).
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
* CSMShadowNode: Fix toggle of `castShadow`. * CSMShadowNode: Add comment.
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
* CSMShadowNode: Fix toggle of `castShadow`. * CSMShadowNode: Add comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #31183
Description
It was not possible so far to toggle the
castShadowproperty of directional lights usingCSMShadowNode.AnalyticLightNodecallsdispose()on shadow nodes that are not used anymore.CSMShadowNodeuses itsdispose()method to remove additions to the scene graph to make cascading work. If the instance ofCSMShadowNodeis now used again (becausecastShadowis set back totrue), the state must be restored. The PR is doing this inupdateBefore().@sunag I have updated
ShadowBaseNodeby removing thedispose()method. SettingupdateBeforeTypetoNodeUpdateType.NONEis an issue since when a shadow node is reused after a dispose,updateBefore()is never executed anymore. BecauseupdateBefore()is not called when lights don't cast shadows, it seems better to not changeupdateBeforeTypeso shadow nodes don't have restore the update type on their own.