Skip to content

SampleNode: Remove PURE annotation.#31293

Merged
sunag merged 1 commit into
mrdoob:devfrom
Mugen87:dev1
Jun 20, 2025
Merged

SampleNode: Remove PURE annotation.#31293
sunag merged 1 commit into
mrdoob:devfrom
Mugen87:dev1

Conversation

@Mugen87

@Mugen87 Mugen87 commented Jun 20, 2025

Copy link
Copy Markdown
Collaborator

Related issue: #31287

Description

@sunag Rollup complains about a PURE annotation in SampleNode. It seems putting the annotation right before an inline function has no effect.

[ROLLUP] (!) src/nodes/utils/SampleNode.js (81:22): A comment
[ROLLUP] 
[ROLLUP] "/*@__PURE__*/"
[ROLLUP] 
[ROLLUP] in "src/nodes/utils/SampleNode.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.

@Mugen87 Mugen87 added this to the r178 milestone Jun 20, 2025
@github-actions

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 337.57
78.74
337.57
78.74
+0 B
+0 B
WebGPU 556.48
154.12
556.48
154.12
+0 B
+0 B
WebGPU Nodes 555.83
153.96
555.83
153.96
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 468.76
113.39
468.76
113.39
+0 B
+0 B
WebGPU 632.23
171.12
632.23
171.12
+0 B
+0 B
WebGPU Nodes 587.28
160.42
587.28
160.42
+0 B
+0 B

@sunag sunag merged commit f7157ee into mrdoob:dev Jun 20, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants