RoundedBoxGeometry: add type, parameters and toJSON#31340
Merged
Conversation
Contributor
Author
|
@Mugen87 Reverting this line: Back to the original: fixes the issue . Should we include this change in this PR or open a new one or something else? 2025-07-01.13-23-48.mp4 |
Collaborator
Let's include it! Good find, btw! 👍 |
Mugen87
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
RoundedBoxGeometry'sparametersobject by default holdsBoxGeometry's parameters (since it extendsBoxGeometry).As a result:
segmentsandradiusvalues passed in the constructor are lost after geometry is created.toJSONmethod returns data relevant to creating aBoxGeometry.This PR
parameterskey hold the actual values passed to create the geometry.geometry.typetoRoundedBoxGeometryinstead ofBoxGeometry.toJSONmethod and make it return the correct data.fromJSONmethod now returns the correctRoundedBoxGeometryinstance instead of aBoxGeometry.The
geometry.parametersbefore and after fornew RoundedBoxGeometry(1, 2, 3, 4, 0.125):Output from
.toJSON():Output from
RoundedBoxGeometry.fromJSON(data)Before and after: