Examples: Improve AA approach in WebGPU water demo.#31354
Merged
Conversation
Collaborator
Author
|
FXAA also produces better results than MSAA when looking flat on the textured surface: MSAA:
FXAA:
I understand that MSAA works better in other places but for this particular scene FXAA seems to produce good results with way better performance. Until |
Collaborator
I'll take a look at that... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Related issue: a9666c6
Description
Unfortunately, enabling MSAA with a MRT setup somewhat kills the performance on mobile. On a Pixel 8a,
webgpu_waterstutters quite noticeably.The PR introduces a more lightweight FXAA which produces still good results but without the overhead of multisampling.
https://rawcdn.githack.com/Mugen87/three.js/ce436cda9e1dd19f77172d30dcb502fe03f7492b/examples/webgpu_water.html
Prod for comparison: https://threejs.org/examples/webgpu_water