PassNode: Provide viewport and scissor API.#31390
Merged
Merged
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
sunag
reviewed
Jul 10, 2025
WestLangley
reviewed
Jul 10, 2025
WestLangley
reviewed
Jul 10, 2025
mrdoob
reviewed
Jul 16, 2025
| this._layers = null; | ||
|
|
||
| /** | ||
| * Scales the resolution of the internal render taregt. |
mrdoob
reviewed
Jul 16, 2025
| * @type {?Vector4} | ||
| * @default null | ||
| */ | ||
| this._customViewport = null; |
Owner
There was a problem hiding this comment.
How about just this._viewport = null;?
If it's null it just uses the renderer one.
Collaborator
Author
There was a problem hiding this comment.
I've fixed the typo and renamed the properties but the fallback to the renderer viewport and scissor needs a bit more though.
mrdoob
reviewed
Jul 16, 2025
| * @type {?Vector4} | ||
| * @default null | ||
| */ | ||
| this._customScissor = null; |
Owner
There was a problem hiding this comment.
How about just this._scissor = null;?
If it's null it just uses the renderer one.
Merged
This was referenced Aug 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #31387
Description
It is currently not possible to define a custom viewport and scissor box when using
pass(). The PR introducessetViewport()andsetScissor()for custom value definition.So in #31387, the OP must use below code in the render loop: