Skip to content

ProjectorLightNode: Remove obsolete toVar().#31474

Merged
Mugen87 merged 1 commit into
mrdoob:devfrom
Mugen87:dev3
Jul 22, 2025
Merged

ProjectorLightNode: Remove obsolete toVar().#31474
Mugen87 merged 1 commit into
mrdoob:devfrom
Mugen87:dev3

Conversation

@Mugen87

@Mugen87 Mugen87 commented Jul 22, 2025

Copy link
Copy Markdown
Collaborator

Related issue: #31459

Description

Thanks to #31459, the code in ProjectorLightNode.getSpotAttenuation() can be simplified.

@Mugen87 Mugen87 added this to the r179 milestone Jul 22, 2025
@github-actions

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 337.92
78.83
337.92
78.83
+0 B
+0 B
WebGPU 560.22
155.11
560.22
155.1
-8 B
-5 B
WebGPU Nodes 559.15
154.89
559.14
154.89
-8 B
-4 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 469.19
113.49
469.19
113.49
+0 B
+0 B
WebGPU 635.39
172.03
635.38
172.03
-8 B
-1 B
WebGPU Nodes 590.04
161.27
590.03
161.27
-8 B
-2 B

@Mugen87 Mugen87 merged commit 868515f into mrdoob:dev Jul 22, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant