SkeletonHelper: Add setColors()#31484
Merged
Merged
Conversation
lukehorvat
commented
Jul 23, 2025
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
lukehorvat
commented
Jul 23, 2025
lukehorvat
commented
Jul 23, 2025
Mugen87
approved these changes
Jul 23, 2025
Merged
This was referenced Aug 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #23829 (comment)
Description
SkeletonHelperalways defaults to green and blue line colors for each bone. These colors might be hard to see on some meshes, so it would be nice to have the option of setting custom colors.I added a
setColors( color1, color2 )method for this purpose, modeled on the existingsetColorsmethods ofCameraHelperandAxesHelper.