Skip to content

SkeletonHelper: Add setColors()#31484

Merged
Mugen87 merged 1 commit into
mrdoob:devfrom
lukehorvat:skeletonhelper-colors
Jul 23, 2025
Merged

SkeletonHelper: Add setColors()#31484
Mugen87 merged 1 commit into
mrdoob:devfrom
lukehorvat:skeletonhelper-colors

Conversation

@lukehorvat

Copy link
Copy Markdown
Contributor

Related issue: #23829 (comment)

Description

SkeletonHelper always defaults to green and blue line colors for each bone. These colors might be hard to see on some meshes, so it would be nice to have the option of setting custom colors.

I added a setColors( color1, color2 ) method for this purpose, modeled on the existing setColors methods of CameraHelper and AxesHelper.

Image

Comment thread examples/webgl_animation_walk.html
@github-actions

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 338.22
78.88
338.22
78.88
+0 B
+0 B
WebGPU 560.22
155.1
560.22
155.1
+0 B
+0 B
WebGPU Nodes 559.14
154.89
559.14
154.89
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 469.49
113.56
469.49
113.56
+0 B
+0 B
WebGPU 635.38
172.03
635.38
172.03
+0 B
+0 B
WebGPU Nodes 590.03
161.27
590.03
161.27
+0 B
+0 B

Comment thread src/helpers/CameraHelper.js
Comment thread src/helpers/SkeletonHelper.js
@Mugen87 Mugen87 added this to the r179 milestone Jul 23, 2025
@Mugen87 Mugen87 merged commit b7c5cc9 into mrdoob:dev Jul 23, 2025
8 of 9 checks passed
@Mugen87 Mugen87 mentioned this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants