Skip to content

TSL: Rename label() to setName().#31490

Merged
sunag merged 2 commits into
mrdoob:devfrom
Mugen87:dev3
Jul 24, 2025
Merged

TSL: Rename label() to setName().#31490
sunag merged 2 commits into
mrdoob:devfrom
Mugen87:dev3

Conversation

@Mugen87

@Mugen87 Mugen87 commented Jul 24, 2025

Copy link
Copy Markdown
Collaborator

Fixed #30703.

Description

Instead of having label() and setName(), the idea is to just use setName() for setting a name property.

Using the set*() syntax also matches more nicely with methods like setGroup() or setPBO().

@github-actions

github-actions Bot commented Jul 24, 2025

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 338.22
78.88
338.22
78.88
+0 B
+0 B
WebGPU 560.23
155.11
560.76
155.2
+533 B
+90 B
WebGPU Nodes 559.15
154.89
559.68
154.98
+533 B
+91 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 469.49
113.56
469.49
113.56
+0 B
+0 B
WebGPU 635.39
172.03
635.76
172.06
+371 B
+29 B
WebGPU Nodes 590.04
161.28
590.41
161.31
+369 B
+31 B

@mrdoob mrdoob added this to the r179 milestone Jul 24, 2025
@sunag sunag merged commit a01368d into mrdoob:dev Jul 24, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add a way to name uniform / texture

3 participants