Src: Nomenclature clean up#31564
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
|
Is this easier to read? |
Maybe, but I don't think "depthbuffer" is a word. |
|
Up to you 👌 |
|
It's a toss-up, but I think this is OK. |
|
new build needed, please. |
|
950dbb5 🚀 |
|
@Mugen87 This change broke user code and should at least be mentioned in the release notes / migration guide 🙏 Related: pmndrs/postprocessing#731 |
|
Thank you! |
|
We only put API changes in the Migration Guide -- not internal changes. The API change was noted in the prior release, r179. If the user is hacking the library, he is responsible for reading what he is hacking. |
|
The library actively provides these macros to I don't see why relying on these predefined macros would be considered hacking.
I'd respect the decision to remove the notes from the migration guide, but I think it's very helpful information. |
|
Yeah, the shader lib is not really internal. At least since the introduction of |
Changed 'reverse' -> 'reversed', plus some subjective changes for clarity