Bindings: Fix caching of texture bindings.#31755
Merged
Merged
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
commented
Aug 26, 2025
|
|
||
| needsBindingsUpdate = true; | ||
|
|
||
| cacheBindings = false; |
Collaborator
Author
There was a problem hiding this comment.
@sunag BTW: The new generation flag was super helpful to identify/isolate this use case!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #31751
Description
I was still experiencing warnings with the WebGPU backend in some occasions. After more debugging, I found out that caching bind groups (which is only done for WebGPU) must not be allowed if
binding.generationwas set totrue. In this case a new GPU texture has been created which must be reflected in the bind group.