WebGLBackend: Align copyTextureToTexture with WebGLRenderer#31810
Merged
Mugen87 merged 4 commits intoSep 3, 2025
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
shotamatsuda
commented
Sep 3, 2025
shotamatsuda
commented
Sep 3, 2025
Mugen87
approved these changes
Sep 3, 2025
Collaborator
|
This PR also fixes the below runtime error that I originally wanted to investigate the next days^^:
It did occur in the first frame in certain examples like webgpu_postprocessing_traa. |
Contributor
Author
|
Oh, fancy that I've just been debugging the same error in my TAA (depth texture on my end) 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #31807
Description
This PR changes the implementation of
copyTextureToTextureforWebGLBackendso that it aligns with the one inWebGLRenderer.It does not handle uninitialized textures the way
WebGLRendererdoes, because it's out of my hands.