Skip to content

WebGLRenderer: Fix WebXR Depth Sensing.#31831

Merged
Mugen87 merged 1 commit into
mrdoob:devfrom
cabanier:fix_depth_sensing
Sep 5, 2025
Merged

WebGLRenderer: Fix WebXR Depth Sensing.#31831
Mugen87 merged 1 commit into
mrdoob:devfrom
cabanier:fix_depth_sensing

Conversation

@cabanier

@cabanier cabanier commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

The introduction of ExternalTexture broke support for WebXR Depth Sensing because the depth texture was never bound to the sampler.
Fixed by doing the same thing in setTexture2DArray as we do for setTexture2D.

cc @Mugen87

This contribution is funded by Meta

@github-actions

github-actions Bot commented Sep 5, 2025

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 338.17
79.12
338.24
79.14
+79 B
+15 B
WebGPU 579.39
160.1
579.39
160.1
+0 B
+0 B
WebGPU Nodes 578
159.86
578
159.86
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 469.76
113.82
469.83
113.84
+79 B
+13 B
WebGPU 649.09
175.75
649.09
175.75
+0 B
+0 B
WebGPU Nodes 603.2
164.92
603.2
164.92
+0 B
+0 B

@cabanier

cabanier commented Sep 5, 2025

Copy link
Copy Markdown
Contributor Author

This is broken in v179 and v180

@Mugen87 Mugen87 merged commit 839287d into mrdoob:dev Sep 5, 2025
9 checks passed
@Mugen87 Mugen87 added this to the r181 milestone Sep 5, 2025
@Mugen87 Mugen87 changed the title fix WebXR Depth Sensing WebGLRenderer: Fix WebXR Depth Sensing. Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants