Skip to content

Examples - Update Compute Fluid to use IndirectStorageBuffer#32176

Merged
Mugen87 merged 1 commit into
mrdoob:devfrom
cmhhelgeson:compute_fluid_indirect
Nov 29, 2025
Merged

Examples - Update Compute Fluid to use IndirectStorageBuffer#32176
Mugen87 merged 1 commit into
mrdoob:devfrom
cmhhelgeson:compute_fluid_indirect

Conversation

@cmhhelgeson

Copy link
Copy Markdown
Contributor

Related Issue: #31488

Description

Update compute fluid to use indirect compute.

@mrdoob

mrdoob commented Nov 4, 2025

Copy link
Copy Markdown
Owner

Does this improve performance?

@cmhhelgeson

Copy link
Copy Markdown
Contributor Author

@Mugen87

Mugen87 commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

I see no difference in performance, tbh.

@RenaudRohlinger

Copy link
Copy Markdown
Collaborator

I don't think in this particular example IndirectStorageBuffer would improve performances as it's too dense, it would need to be a lot wider to have some inactive particles or update the particleCount to make it a uniform dynamic count that doesn't restart the simulation but rather just disable the inactive particles.

Nevertheless it's always good to have some Indirect example so that developers can understand how it works!

@Mugen87

Mugen87 commented Nov 29, 2025

Copy link
Copy Markdown
Collaborator

Nevertheless it's always good to have some Indirect example so that developers can understand how it works!

I'm okay with merging the PR because of that reason.

Normally the examples should use simple setups with the minimal amount of code that is required to demonstrate an effect. But for learning and further developed it's indeed good to have a few indirect compute examples around.

@Mugen87 Mugen87 added this to the r182 milestone Nov 29, 2025
@Mugen87 Mugen87 merged commit 306706d into mrdoob:dev Nov 29, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants