Skip to content

WebGPUBindingUtils - Buffer Labeling Adjustment#32247

Merged
sunag merged 4 commits into
mrdoob:devfrom
cmhhelgeson:modify_binding_label
Nov 13, 2025
Merged

WebGPUBindingUtils - Buffer Labeling Adjustment#32247
sunag merged 4 commits into
mrdoob:devfrom
cmhhelgeson:modify_binding_label

Conversation

@cmhhelgeson

Copy link
Copy Markdown
Contributor

Related issue: #32037

Description

Add better labeling to the buffers generated from NodeUniformsGroup bindings, specifying the id of the binding the buffer was created from as well as the buffer's visibility.

Comment thread src/renderers/webgpu/utils/WebGPUBindingUtils.js Fixed
@github-actions

github-actions Bot commented Nov 11, 2025

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 356.24
86.48
356.24
86.48
+0 B
+0 B
WebGPU 613.68
172.23
613.85
172.25
+169 B
+27 B
WebGPU Nodes 612.28
171.97
612.45
172
+169 B
+26 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 488.04
121.25
488.04
121.25
+0 B
+0 B
WebGPU 683.1
187.49
683.26
187.52
+169 B
+39 B
WebGPU Nodes 624.82
170.72
624.99
170.76
+169 B
+40 B

@cmhhelgeson

Copy link
Copy Markdown
Contributor Author

Interesting, I don't think I've ever seen the tests default to the WebGLBackend before.

@cmhhelgeson cmhhelgeson changed the title WebGPUBindingUtils - Buffer Labeling WebGPUBindingUtils - Buffer Labeling Adjustment Nov 12, 2025
Comment thread src/renderers/webgpu/utils/WebGPUBindingUtils.js Outdated
Comment thread src/renderers/webgpu/utils/WebGPUBindingUtils.js
@sunag sunag added this to the r182 milestone Nov 12, 2025
@sunag sunag merged commit f9dced0 into mrdoob:dev Nov 13, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants