Material: Fix copy method to include allowOverride property#32269
Merged
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
reviewed
Nov 14, 2025
The copy method in Material was missing the allowOverride property that is defined in the constructor. When cloning a Material instance, this property was not copied to the new material, causing incorrect behavior when allowOverride was set to false. Fixed by ensuring allowOverride is properly copied in the copy method.
Honor `allowOverride` in `toJSON()`
Mugen87
approved these changes
Nov 15, 2025
Collaborator
|
I have added ba1655c to make sure deserialization works as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The copy method in Material was missing the allowOverride property that is defined in the constructor. When cloning a Material instance, this property was not copied to the new material, causing incorrect behavior when allowOverride was set to false.
Fixed by ensuring allowOverride is properly copied in the copy method.
Related issue: N/A
Description
The copy method in Material was missing the allowOverride property that is defined in the constructor. When cloning a Material instance, this property was not copied to the new material, causing incorrect behavior when allowOverride was set to false.